Update react native 0.50.3 #2217

yenda · 2017-10-19T04:44:39Z

TODOS:

- [x] Android migration
- [x] iOS migration
- [x] move all github repos in package.json to Status repos

Test:
This changes react-native version and update most libraries in the process. But there is no changes to our code itself so if the app loads, tabs work, scrolling work, drawer works it should be good.

status: ready

rasom · 2017-11-06T09:39:58Z

android/app/src/main/java/im/status/ethereum/MainApplication.java

@@ -73,7 +74,7 @@ public boolean getUseDeveloperSupport() {
                    new ReactNativeDialogsPackage(),
                    new ImageResizerPackage(),
                    new PickerPackage(),
-                    new WebViewBridgePackage(BuildConfig.DEBUG, callRPC),


We definitely need to pass callRPC to WebViewBridgePackage

oskarth · 2017-11-09T15:00:20Z

@yenda What's the state of this PR?

oskarth · 2017-11-13T14:55:55Z

ios/StatusIm.xcodeproj/project.pbxproj

@@ -43,6 +43,7 @@
 		81C6E6AE0AA739BE9D87C1D0 /* libPods-StatusImTests.a in Frameworks */ = {isa = PBXBuildFile; fileRef = FC1CBCFE6C906043D6CCEEE1 /* libPods-StatusImTests.a */; };
 		82E689BAF9FB43C8AC6FF1CA /* EvilIcons.ttf in Resources */ = {isa = PBXBuildFile; fileRef = CEB0E2659D1A4F5FA842057A /* EvilIcons.ttf */; };
 		832341BD1AAA6AB300B99B32 /* libRCTText.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 832341B51AAA6A8300B99B32 /* libRCTText.a */; };
+<<<<<<< ours


Merge conflicts shouldn't be committed

oskarth · 2017-11-13T15:31:45Z

Please specify version of RN we are upgrading to; when issue was created latest stable was 0.47, now it is 0.50. Is this the one we use?

oskarth · 2017-11-14T11:33:34Z

Relevant issue for iOS upgrade and unable to open Xcode: facebook/react-native#12261

oskarth · 2017-11-14T12:17:03Z

My removal of the merge conflicted pbxproject file was a mistake; please ignore this noop.
I thought this RN iOS upgrade stuff would be fairly straightforward with all the work @yenda had already done, but it looks like it is a bunch of indeterminate work. This seems like it is within the scope of Improve developer experience on status-react swarms#9 swarm (4 devs committed), and I'd rather spend time kickstarting offline inboxing swarm since I'm leading that one.
Why it seems like indeterminate work:

apply common sense merge (use both and make sure all structures are enclosed properly, remove duplicates) => Xcode won't open.
Apply only their changes => pod install => whole project file nuked
Long thread in official repo from February with no canonical solution using current upgrade path

So for all I know it could take a week. It might also take an hour if you find the right combination. One idea is to start RN upgrade from scratch on iOS side, don't use the magic git upgrade script, and then merge that upgrade with this one. We could also put up a bounty to get some Xcode ninjas to resolve this.

janherich · 2017-11-21T23:47:56Z

The last status - except for changes here, one needs to change the import in header files of the react-native-http-bridge and instabug-reactnative from #import "RCTBridgeModule.h" to #import <React/RCTBridgeModule.h> (see this thread about the issue - facebook/react-native#15775).
I patched them in my node_modules folder, but of course this needs to be fixed in upstream repositories.
After that, the build fails on the linker invocation, which can't find the GoogleToolboxForMaxLibrary despite the framework being there and referenced correctly in the project.pbxproj file, see screenshot:

yenda · 2017-11-22T00:12:39Z

@janherich can you fork the libs until they are fixed upstream because node_modules is local. We might want to do this for all libs anyway

oskarth · 2017-11-22T23:58:17Z

I decided to attack this a bit. I didn't read your comment in detail beforehand, but I did the same thing as you did. Attached patch files which makes it reproducible.

Issue that is quickfix: #2505

Issue for thing afterwards: #2506

oskarth · 2017-11-23T11:30:14Z

package.json

@@ -29,7 +29,7 @@
    "homoglyph-finder": "1.1.1",
    "https-browserify": "0.0.1",
    "identicon.js": "github:status-im/identicon.js",
-    "instabug-reactnative": "git+https://github.com/status-im/instabug-reactnative.git",


How come you don't update the status-im one? We should use that, not our own forks.

If it is a permission issue and you do this to be unblocked: OK - please ping Carl and/or Nabil and he will sort you (us) out.

^ @janherich

oskarth · 2017-11-23T11:30:24Z

package.json

@@ -29,7 +29,7 @@
    "homoglyph-finder": "1.1.1",
    "https-browserify": "0.0.1",
    "identicon.js": "github:status-im/identicon.js",
-    "instabug-reactnative": "git+https://github.com/status-im/instabug-reactnative.git",


^ @janherich

oskarth · 2017-11-23T11:31:09Z

package.json

@@ -55,7 +55,7 @@
    "react-native-fcm": "10.0.3",
    "react-native-fs": "2.8.1",
    "react-native-http": "github:tradle/react-native-http#834492d",
-    "react-native-http-bridge": "github:yenda/react-native-http-bridge",
+    "react-native-http-bridge": "github:janherich/react-native-http-bridge",


hot potato :D

oskarth · 2017-11-23T11:32:05Z

package.json

    "https-browserify": "0.0.1",
    "identicon.js": "github:status-im/identicon.js",
-    "instabug-reactnative": "git+https://github.com/status-im/instabug-reactnative.git",
-    "nfc-react-native": "github:status-im/nfc-react-native",
+    "instabug-reactnative": "git+https://github.com/janherich/instabug-reactnative.git",


Comment appeared as outdated, not sure why. 54f5bcb#r152777933

I assume this is due to permission issues, ping Carl and Nabil in slack on this

janherich · 2017-11-26T11:17:19Z

@yenda everything works on iOS side (including re-frisk/figwheel in dev mode) I propose that you will pull the newest changes, make sure that everything is still working on the Android side, and we can then request comprehensive regression testing from QA.
Once this is completed, I can then squash commits, transfer forked repo changes to repositories owned by status-im organisation and finally rebase and merge it into develop :)

yenda · 2017-12-08T22:06:46Z

Branch: status-im:update-react-native
Android: https://i.diawi.com/CSM6ZK
iOS: https://i.diawi.com/W9A8hm

asemiankevich · 2017-12-11T12:15:09Z

No commands shown after second launch (known, fixed in develop)
No dot/comma is shown on keyboard when requesting/sending funds #2681. This is fixed in 0.9.10-438-g6948dd17+ branch
Picture in user profile is not updated when selecting from gallery or capture [2217] #2682. This is fixed in 0.9.10-438-g6948dd17+ branch
ios build can not be started
Null is not an object (evaluating 'e.toLowerCase') error shown [2217] #2697. This is closed as duplicate of After upgrade: null is not an object (evaluating 'e.toLowerCase') if last message in chat is Request #2602. Moreover it is in develop and is not related to current branch
Invariat Violation error shown when opening transaction history screen [2217] #2709

asemiankevich · 2017-12-14T13:55:12Z

All issues above are fixed in branch below. No new issues found. I assume we can merge this.

Branch: status-im:update-react-native
Android: https://i.diawi.com/x1acKd
iOS: https://i.diawi.com/bwcauj

[#bug] fix realm version

yenda self-assigned this Oct 19, 2017

yenda added the tech-debt label Oct 19, 2017

yenda mentioned this pull request Oct 24, 2017

[RFC] Improve developper experience #2294

Closed

9 tasks

yenda added the blocker label Oct 25, 2017

rasom reviewed Nov 6, 2017

View reviewed changes

yenda force-pushed the update-react-native branch 8 times, most recently from 1c2df27 to 53a998e Compare November 10, 2017 14:26

yenda mentioned this pull request Nov 10, 2017

Improve developer experience on status-react status-im/swarms#9

Closed

3 tasks

yenda force-pushed the update-react-native branch 2 times, most recently from 9642373 to d97c171 Compare November 11, 2017 08:04

oskarth reviewed Nov 13, 2017

View reviewed changes

yenda changed the title ~~[WIP] Update react native~~ [WIP] Update react native 0.50.3 Nov 13, 2017

yenda force-pushed the update-react-native branch from 4f4d8fb to 89c793d Compare November 14, 2017 17:44

janherich self-assigned this Nov 16, 2017

oskarth reviewed Nov 23, 2017

View reviewed changes

janherich force-pushed the update-react-native branch from 912ad65 to b2133fb Compare November 25, 2017 18:48

janherich force-pushed the update-react-native branch from 4b356c0 to e0c86ae Compare November 27, 2017 09:35

yenda force-pushed the update-react-native branch 2 times, most recently from c838456 to 25ec360 Compare December 8, 2017 21:44

yenda changed the title ~~[WIP] Update react native 0.50.3~~ Update react native 0.50.3 Dec 8, 2017

yenda force-pushed the update-react-native branch from 25ec360 to a62c1a7 Compare December 11, 2017 13:48

asemiankevich mentioned this pull request Dec 12, 2017

Unable to run iOS builds #2698

Closed

yenda force-pushed the update-react-native branch from 505d287 to ec74efe Compare December 13, 2017 08:55

asemiankevich self-assigned this Dec 14, 2017

asemiankevich added the Tested - OK label Dec 14, 2017

janherich force-pushed the update-react-native branch from 8e66045 to bf73951 Compare December 14, 2017 17:36

yenda force-pushed the update-react-native branch from a76727b to f222940 Compare December 15, 2017 14:08

update react-native and project dependencies

f472881

[#bug] fix realm version

yenda force-pushed the update-react-native branch from f222940 to f472881 Compare December 15, 2017 15:03

rasom approved these changes Dec 15, 2017

View reviewed changes

yenda merged commit 56c59c7 into develop Dec 15, 2017

rasom deleted the update-react-native branch December 21, 2017 10:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update react native 0.50.3 #2217

Update react native 0.50.3 #2217

yenda commented Oct 19, 2017 •

edited

Loading

rasom Nov 6, 2017

oskarth commented Nov 9, 2017

oskarth Nov 13, 2017

oskarth commented Nov 13, 2017

oskarth commented Nov 14, 2017

oskarth commented Nov 14, 2017 •

edited

Loading

janherich commented Nov 21, 2017

yenda commented Nov 22, 2017

oskarth commented Nov 22, 2017 •

edited

Loading

oskarth Nov 23, 2017

oskarth Nov 23, 2017

oskarth Nov 23, 2017

oskarth Nov 23, 2017

oskarth Nov 23, 2017

oskarth Nov 23, 2017

janherich commented Nov 26, 2017

yenda commented Dec 8, 2017

asemiankevich commented Dec 11, 2017 •

edited

Loading

asemiankevich commented Dec 14, 2017 •

edited

Loading

Update react native 0.50.3 #2217

Update react native 0.50.3 #2217

Conversation

yenda commented Oct 19, 2017 • edited Loading

Choose a reason for hiding this comment

oskarth commented Nov 9, 2017

Choose a reason for hiding this comment

oskarth commented Nov 13, 2017

oskarth commented Nov 14, 2017

oskarth commented Nov 14, 2017 • edited Loading

janherich commented Nov 21, 2017

yenda commented Nov 22, 2017

oskarth commented Nov 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janherich commented Nov 26, 2017

yenda commented Dec 8, 2017

asemiankevich commented Dec 11, 2017 • edited Loading

asemiankevich commented Dec 14, 2017 • edited Loading

All issues above are fixed in branch below. No new issues found. I assume we can merge this.

yenda commented Oct 19, 2017 •

edited

Loading

oskarth commented Nov 14, 2017 •

edited

Loading

oskarth commented Nov 22, 2017 •

edited

Loading

asemiankevich commented Dec 11, 2017 •

edited

Loading

asemiankevich commented Dec 14, 2017 •

edited

Loading