Prevent non-positive-number amounts for send / request commands (#668) #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GustavoNunes
force-pushed
the
bug/request-null-eth-#668
branch
from
6141947
to
66c9e97
Compare
|
Thanks for the contribution @GustavoNunes ! |
|
@GustavoNunes /request cmd is requesting for Zero amount also. Should validate that requested amount is > 0.Please see attached screenshot. Status Version - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix to prevent non-numbers in request command. Used the same check as the send command (web3.toWei).
Also preventing 0 or negative amount, as I believe makes no sense (I was able to "send -3 ether", but the app crashed when it tried to confirm the transaction).
fixes #668