feat: add lapack/base/dptts2
#2625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranavchiku
added
Feature
Pranavchiku
commented
Jul 22, 2024
Pranavchiku
commented
Jul 22, 2024
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
commented
Jul 22, 2024
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
kgryte
added
the
Needs Changes
Pranavchiku
commented
Aug 3, 2024
Pranavchiku
commented
Aug 3, 2024
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
added
Needs Review
|
I think this PR can now have a final review. |
kgryte
reviewed
Sep 17, 2024
|
|
||
| b.tic(); | ||
| for ( i = 0; i < b.iterations; i++ ) { | ||
| B = uniform( len * len, -10.0, 10.0, options ); |
There was a problem hiding this comment.
Do not allocate new arrays in benchmarks. Results will be tainted with non-relevant operations.
kgryte
reviewed
Sep 17, 2024
|
|
||
| b.tic(); | ||
| for ( i = 0; i < b.iterations; i++ ) { | ||
| B = uniform( len * len, -10.0, 10.0, options ); |
kgryte
reviewed
Sep 17, 2024
| B[ ob + ( ( N - 1 ) * strideB1 ) ] /= D[ offsetD + ( ( N - 1 ) * strideD ) ]; | ||
| se = N - 2; | ||
| for ( i = N - 2; i >= 0; i-- ) { | ||
| B[ ob + ( i * strideB1 ) ] = ( B[ ob + ( i * strideB1 ) ] / D[ offsetD + ( i * strideD ) ] ) - ( E[ offsetE + se ] * B[ ob + ( ( i + 1) * strideB1 ) ] ); |
There was a problem hiding this comment.
You have repeated computation of index offsets. Refactor and simplify.
kgryte
reviewed
Sep 17, 2024
| expected = new Float64Array( [ 11.0, 38.0, -5.0, -18.0, 2.0, 6.0 ] ); | ||
| out = dptts2( 'row-major', 3, 2, D, E, B, 2 ); | ||
| t.strictEqual( out, B, 'returns expected value' ); | ||
| isApprox( t, B, expected, 1.0e-7 ); |
There was a problem hiding this comment.
Why 1.0e-7? This tolerance does not make sense to me. That effectively makes the tol value 0 in isApprox.
kgryte
reviewed
Sep 17, 2024
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function solves a tridiagonal system of the form `A * X = B` using `L * D * L^T` factorization of `A` (row-major, offsetD=3, offsetE=4, offsetB=6)', function test( t ) { |
There was a problem hiding this comment.
Parameterizing with explicit values does not mean much to the casual reader. What is this test (and the ones which follow) indicated to show?
kgryte
reviewed
Sep 17, 2024
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function solves a tridiagonal system of the form `A * X = B` using `L * D * L^T` factorization of `A` (row-major, offsetD=3, strideD=2, offsetE=4, offsetB=6)', function test( t ) { |
There was a problem hiding this comment.
Here, you are testing that the function supports a D stride. Update the description accordingly.
kgryte
reviewed
Sep 17, 2024
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function solves a tridiagonal system of the form `A * X = B` using `L * D * L^T` factorization of `A` (row-major, strideB1=-2, strideB2=-1)', function test( t ) { |
There was a problem hiding this comment.
Here, you are showing that the function supports negative strides for B. Update the description accordingly. Etc.
kgryte
reviewed
Sep 17, 2024
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function solves a tridiagonal system of the form `A * X = B` using `L * D * L^T` factorization of `A` (row-major, strideB1=-3, strideB2=-2)', function test( t ) { |
There was a problem hiding this comment.
All your tests are row-major. You need to also systematically test behavior for column-major.
kgryte
added
Needs Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2464
Description
This pull request adds initial implementation for
lapack/base/dptts2.Related Issues
No.
Questions
No.
Other
No.
Checklist
TODO:
strideB1,strideB2.@stdlib-js/reviewers