Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update add-on, benchmarks, tests, and examples #800

Merged
merged 17 commits into from
Mar 1, 2023

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Jan 24, 2023

Checklist

  • update readme.md
  • docs
  • src
  • include.gypi
  • manifest.json
  • package.json
  • lib
  • examples
  • benchmark
  • test

@kgryte

@Pranavchiku Pranavchiku changed the title update readme Refactor @stdlib/blase/base/snrm2 Jan 24, 2023
@Pranavchiku Pranavchiku added Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). labels Jan 24, 2023
@Pranavchiku
Copy link
Member Author

Some tests are failing, below is given log

# the function supports a negative `stride` parameter
not ok 9 returns expected value
  ---
    operator: equal
    expected: 5
    actual:   0
    at: Test.test (/home/pranavchiku/stdlib/lib/node_modules/@stdlib/blas/base/snrm2/test/test.ndarray.native.js:124:4)
  ...

I am not sure why it is happening, @kgryte if you can have a look.

@kgryte
Copy link
Member

kgryte commented Jan 31, 2023

@Pranavchiku The test failures are due to your having removed the logic for ensuring that the stride is positive: https://github.com/stdlib-js/stdlib/pull/800/files#diff-a0af2215d328eb25f7e66afb3ee4a6b38e251a677a27096c8efb6fe1bbedbf92L50. The reference BLAS implementation does not support negative strides. So for the ndarray API (which does support negative strides), we need to convert to positive before passing down to C.

@Pranavchiku
Copy link
Member Author

Okay, I will have a look asap.

@kgryte
Copy link
Member

kgryte commented Feb 14, 2023

@Pranavchiku LMK once this PR has been updated, and I'll take another look.

@Pranavchiku
Copy link
Member Author

@kgryte updated this PR, you can have a review.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Pranavchiku!

@kgryte
Copy link
Member

kgryte commented Mar 1, 2023

@Pranavchiku This PR is currently marked as a draft. I assume that this is ready for merge?

@Pranavchiku Pranavchiku marked this pull request as ready for review March 1, 2023 09:59
@Pranavchiku
Copy link
Member Author

I assume that this is ready for merge?

Yes, I forgot to make it ready to review.

@kgryte kgryte changed the title Refactor @stdlib/blase/base/snrm2 refactor: update add-on, benchmarks, tests, and examples Mar 1, 2023
@kgryte kgryte merged commit 710ea41 into stdlib-js:develop Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants