Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script tag wins against global steal object #579

Merged
merged 3 commits into from
Feb 22, 2016
Merged

Script tag wins against global steal object #579

merged 3 commits into from
Feb 22, 2016

Conversation

pYr0x
Copy link
Collaborator

@pYr0x pYr0x commented Feb 14, 2016

with stealjs/steal-tools#370 now css files should loaded correctly and baseUrl should be not overwritten
https://github.com/stealjs/steal/blob/master/src/config.js#L324

this fix some of the problems with
#578

@matthewp
Copy link
Member

Hi, thanks for submitting. Given that #578 probably covers several different issues please describe specifically what this commit fixes. It looks like it is related to bundleSteal, what specifically does this fix?

@pYr0x pYr0x changed the title fix some of the problems with #578 Script tag wins against global steal object Feb 16, 2016
@pYr0x
Copy link
Collaborator Author

pYr0x commented Feb 16, 2016

talked to @matthewp
rewrite the PR. provide a test.
now we can write a global steal object like

<script>
    steal = {
        foo: 'bar'
    };
</script>

and steal merge that into the System-loader.

if a script tag attribute is provided, the property in System will be overwritten.
this is necessary because of this issue: stealjs/steal-tools#377
we now set

steal.baseURL = './';

on files where steal is bundled in. if the user would change the baseURL he can write into the script tag or config.

matthewp added a commit that referenced this pull request Feb 22, 2016
Script tag wins against global steal object
@matthewp matthewp merged commit 72fbe00 into stealjs:master Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants