Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagban command does not work #40

Closed
Davnit opened this issue Mar 8, 2017 · 1 comment

Comments

@Davnit
Copy link
Collaborator

commented Mar 8, 2017

[00:54:47.296] <Pyro> .tagban CODE
[00:54:48.267] <StealthBot> You must specify a user to add.
[00:54:50.553] <Pyro> wat
[00:55:32.943] <Pyro> .tagban code aaaa
[00:55:33.385] <StealthBot> You must specify a user to add.

@Davnit Davnit added the bug label Mar 8, 2017

@Davnit

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 8, 2017

I've also experienced the same result with the /cadd command (client ban).

Davnit added a commit that referenced this issue Mar 13, 2017

Overhaul internal user database system
- Get rid of udtGetAccessResponse and udtDatabase, which were basically
2 implementation of the exact same thing.
- Move user database functionality to a separate class, globally
referenced as "Database"
- Database entries are now stored (in memory) as clsDBEntryObj objects.
- Access inquiries return a udtUserAccess object which does not contain
any of the metadata associated with the entry it's based on, only
access-related information.
- A local, deep copy of the database and its objects can be obtained by
using obj.CreateCopy(). The database manager has been retrofitted to use
this new functionality.
- Got rid of OnAddOld() and OnRemOld(). OnAdd() now parses arguments and
passes the request off to the database class through
Database.HandleAddCommand(). Commands that were previously based on add
(shitadd, tagadd, safeadd + their del counterparts) also use this
interface.
- Removing a group no longer removes all of the members of that group.
They are moved to another one of their parent groups or the root node if
they don't have any. Fixes #39

Unrelated to the database changes but which got lumped in here...
- Several command behavior fixes. Many commands were doing redundant
checks or recreating "console" access on their own. Console access can
be acquired from the database class through Database.GetConsoleAccess().
- Fixed some commands that did not respond when invalid.
- Renamed the internal (console) user to <console> since the former is
now a valid username. Fixes #41
- Fixed tagban command, issue #40
- Fixed some issues with the database manager not showing all entries

Probably fixed and broke a few other things that were minor and I've
forgotten about.

@Davnit Davnit closed this Mar 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.