Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command line interface compatibility breakage #3025

Closed
theoreticalbts opened this issue Oct 3, 2018 · 1 comment
Closed

Fix command line interface compatibility breakage #3025

theoreticalbts opened this issue Oct 3, 2018 · 1 comment
Assignees

Comments

@theoreticalbts
Copy link
Contributor

#3014 was unintentionally an incompatible change to the command-line interface. The problem here is that, in some places, the option needs to be separately added to the config and command line options. This cannot be done because here the plugin-specified options are added to both the config and command-line options.

So I propose the following refactoring:

  • In every plugin's set_program_options(), have the common options for cli / cfg added to cfg as presently
  • Add the line cli.add(cfg); to the plugin
  • This is a pure refactoring, we've just moved the logic of "add everything in cfg to cli" from appbase to each individual plugin
  • For every former bool_switch() option, after cli.add(cfg);, add bool_switch() to cli
  • For every former bool_switch() option, after cli.add(cfg);, add value<bool> to cfg
@theoreticalbts
Copy link
Contributor Author

#3024 will probably have to be reverted when this is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants