Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative vesting withdrawals #2583

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

mvandeberg
Copy link
Contributor

No description provided.

Copy link

@goldibex goldibex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mvandeberg mvandeberg merged commit ecb2a90 into stable Jul 3, 2018
@syvb
Copy link
Contributor

syvb commented Jul 3, 2018

Won't this cause forking among non-upgraded witnesses if another such attack were to happen? Wouldn't it be better to only ignore these transactions if the witness if producing?

@TimCliff
Copy link
Contributor

TimCliff commented Jul 3, 2018

@Smittyvb non-upgraded witnesses will already not be able to receive and process blocks until they apply the patch.

@mvandeberg mvandeberg deleted the 20180702-fix-vesting-withdrawal-stable branch October 23, 2018 22:25
kirkins referenced this pull request in steemit/condenser Jan 8, 2019
Adding user to list due to ToS violation of steemit.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants