Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts in "@user/posts" are now stored as author/permlink. #449

Merged
merged 2 commits into from
Sep 22, 2016

Conversation

mvandeberg
Copy link
Contributor

Fix and document get_replies_by_last_update
#445

Fix and document get_replies_by_last_update
#445
@theoreticalbts
Copy link
Contributor

  • Needs FC_ASSERT( limit <= k ); for some fixed k (maybe 1000?)
  • Should explicitly handle the case where both strings are empty (i.e. add else clause after else if)

@mvandeberg
Copy link
Contributor Author

k should be 100 as used by discussion_query

struct discussion_query {
   void validate()const{
      FC_ASSERT( filter_tags.find(tag) == filter_tags.end() );
      FC_ASSERT( limit <= 100 );
   }

   string           tag;
   uint32_t         limit = 0;
   set<string>      filter_tags;
   optional<string> start_author;
   optional<string> start_permlink;
   optional<string> parent_author;
   optional<string> parent_permlink;
};

The else case is handled implicitly by

auto itr = last_update_idx.begin();

I can add an else case

else
   itr = last_update_idx.begin();

But that seems redundant...

@mvandeberg mvandeberg merged commit f271bfb into develop Sep 22, 2016
@mvandeberg mvandeberg deleted the 445-api-fixes branch September 22, 2016 21:10
On1x pushed a commit to VIZ-Blockchain/viz-cpp-node that referenced this pull request May 28, 2018
…or-linear-reward-curve

Remove stop time for linear reward curve. steemit#447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants