Ability to enter a witness username manually #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Someguy123
commented
Aug 11, 2016
Someguy123
commented
It's not stated anywhere on the README, so I added it to the dependencies, and suggested nvm (which is pretty important for anyone who works on more than one node project)
|
Could you put the input box at the bottom instead of top? |
|
Done. @valzav |
|
Great! I will merge it but please submit it next time to develop branch - master is only for the stable version. |
|
Ah okay, thanks valzaz. I'll keep that in mind. I saw other PR's to the master branch, plus there's nothing in the README to say this, or any contributing guidelines etc... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.