Skip to content

Commit

Permalink
net/hns3: fix handling link update
Browse files Browse the repository at this point in the history
[ upstream commit fae9b06 ]

The link fails code should be parsed using the structure
hns3_mbx_vf_to_pf_cmd, else it will parse fail.

Fixes: 109e4dd ("net/hns3: get link state change through mailbox")

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
  • Loading branch information
fengchengwen authored and steevenlee committed Jun 8, 2021
1 parent adefa69 commit 551f319
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions drivers/net/hns3/hns3_mbx.c
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ hns3_link_fail_parse(struct hns3_hw *hw, uint8_t link_fail_code)

static void
hns3_handle_link_change_event(struct hns3_hw *hw,
struct hns3_mbx_pf_to_vf_cmd *req)
struct hns3_mbx_vf_to_pf_cmd *req)
{
#define LINK_STATUS_OFFSET 1
#define LINK_FAIL_CODE_OFFSET 2
Expand Down Expand Up @@ -524,7 +524,14 @@ hns3_dev_handle_mbx_msg(struct hns3_hw *hw)
hns3_mbx_handler(hw);
break;
case HNS3_MBX_PUSH_LINK_STATUS:
hns3_handle_link_change_event(hw, req);
/*
* This message is reported by the firmware and is
* reported in 'struct hns3_mbx_vf_to_pf_cmd' format.
* Therefore, we should cast the req variable to
* 'struct hns3_mbx_vf_to_pf_cmd' and then process it.
*/
hns3_handle_link_change_event(hw,
(struct hns3_mbx_vf_to_pf_cmd *)req);
break;
case HNS3_MBX_PUSH_VLAN_INFO:
/*
Expand Down

0 comments on commit 551f319

Please sign in to comment.