Skip to content

Commit

Permalink
fix case where people set maintainers wrong
Browse files Browse the repository at this point in the history
  • Loading branch information
stefanjudis committed Oct 25, 2015
1 parent a079f67 commit 30068ca
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
6 changes: 6 additions & 0 deletions util/package.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ function getMaintainers( packageJson ) {
} );
}

// safety fix for people doing
// -> "maintainers" : "Bob <some.email>"
if ( typeof packageJson.maintainers === 'string' ) {
packageJson.maintainers = [ getPersonObject( packageJson.maintainers ) ];
}

return packageJson.maintainers ?
packageJson.maintainers :
false;
Expand Down
14 changes: 14 additions & 0 deletions util/package.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,20 @@ test( 'getMaintainers - maintainers is not defined', t => {
t.end();
} );

test( 'getMaintainers - maintainers is an invalid string', t => {
let packageJson = {
maintainers : 'Bob Calsow <bob@calsow.io> (http://4waisenkinder.de)'
};

let maintainers = packageUtil.getMaintainers( packageJson );

t.same(
maintainers[ 0 ],
{ name : 'Bob Calsow', email : 'bob@calsow.io', url : 'http://4waisenkinder.de' }
);
t.end();
} );

test( 'getMaintainers - maintainers is not defined', t => {
let packageJson = {};

Expand Down

0 comments on commit 30068ca

Please sign in to comment.