fix case where people set maintainers wrong

stefanjudis · Oct 25, 2015 · 30068ca · 30068ca
1 parent a079f67
commit 30068ca
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/util/package.js b/util/package.js
@@ -58,6 +58,12 @@ function getMaintainers( packageJson ) {
     } );
   }
 
+  // safety fix for people doing
+  // -> "maintainers" : "Bob <some.email>"
+  if ( typeof packageJson.maintainers === 'string' ) {
+    packageJson.maintainers = [ getPersonObject( packageJson.maintainers ) ];
+  }
+
   return packageJson.maintainers ?
           packageJson.maintainers :
           false;

diff --git a/util/package.spec.js b/util/package.spec.js
@@ -103,6 +103,20 @@ test( 'getMaintainers - maintainers is not defined', t => {
   t.end();
 } );
 
+test( 'getMaintainers - maintainers is an invalid string', t => {
+  let packageJson = {
+    maintainers : 'Bob Calsow <bob@calsow.io> (http://4waisenkinder.de)'
+  };
+
+  let maintainers = packageUtil.getMaintainers( packageJson );
+
+  t.same(
+    maintainers[ 0 ],
+    { name : 'Bob Calsow', email : 'bob@calsow.io', url : 'http://4waisenkinder.de' }
+  );
+  t.end();
+} );
+
 test( 'getMaintainers - maintainers is not defined', t => {
   let packageJson = {};