Use project.root for ember generate #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses ember-cli#1153 Refactors Blueprint. Here are the details: Refactor Blueprint Lookup: The only default lookup path is ember-cli’s own blueprints directory. Any other lookup paths must be passed explicitly. Blueprint.lookup('foo', { paths: [project.blueprintsPath()] }); Refactor Blueprint Construction: The constructor takes only the path to the blueprint directory. The options `ui`, `analytics` and `project` should now be passed to `install`. var blueprint = new Blueprint('my/cool/blueprint'); blueprint.install({ target: this.project.root, entity: { name: 'foo' }, ui: this.ui, analytics: this.analytics, project: this.project });
|
Awesome thanks! |
stefanpenner
added a commit
that referenced
this pull request
Jun 26, 2014
Use project.root for ember generate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1153
Refactors Blueprint. Here are the details:
Refactor Blueprint Lookup:
The only default lookup path is ember-cli’s own blueprints directory.
Any other lookup paths must be passed explicitly.
Refactor Blueprint Construction:
The constructor takes only the path to the blueprint directory. The
options
ui,analyticsandprojectshould now be passed toinstall.