Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addon.postBuild hook #1215

Merged

Conversation

jakecraige
Copy link
Member

implement a postBuild hook in the builder addons can use to run arbitrarary code after each build

This allows an added to hook into the build/rebuild process and return a promise that will be passed the results from the processBuildResult method.

My use case for this is that after every rebuild, I need to run cordova build ios on the command line but it does not affect the output of the js/css files so it needs to be after everything is done

@jakecraige jakecraige changed the title implement a postBuild hook in the builder addons can use to run arbitrar... addon.postBuild hook Jun 30, 2014
@jakecraige jakecraige changed the title addon.postBuild hook Add addon.postBuild hook Jun 30, 2014
build: function() {
return this.builder.build.apply(this.builder, arguments)
.then(this.processBuildResult.bind(this));
.then(this.processBuildResult.bind(this)).then(this.addonsPostBuild.bind(this));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this down to the next line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjackson done

@jakecraige
Copy link
Member Author

@rjackson fixed and rebased. should pass this time around, lol

@jakecraige
Copy link
Member Author

@rjackson looks like we need a rerun, just one failed

@rwjblue
Copy link
Member

rwjblue commented Jul 1, 2014

LGTM

@stefanpenner - +1/-1?

stefanpenner added a commit that referenced this pull request Jul 1, 2014
@stefanpenner stefanpenner merged commit f9c4e7c into ember-cli:master Jul 1, 2014
@jakecraige jakecraige deleted the feature/addon_build_hooks branch July 4, 2014 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants