Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Update ember-macro-helpers version, drops Node 6 support #314

Merged
merged 2 commits into from
Aug 25, 2019
Merged

[BREAKING] Update ember-macro-helpers version, drops Node 6 support #314

merged 2 commits into from
Aug 25, 2019

Conversation

GreatWizard
Copy link
Contributor

@GreatWizard GreatWizard commented Aug 8, 2019

I had conflict versions of browserslist dependency in my ember-cli-postcss pipeline and I wasn"t able to use a query like > .2% and lastest 2 versions... because ember-moment use an old version of ember-macro-helpers which use an old version of ember-weakmap which use an old version of browserslist (v3.x) ... :D

⚠️ The latest ember-macro-helpers needs to run at least on node v8.* ... so I guess if we merge this PR, a major version of ember-moment will come.

Temporary, I fixed it in my project by using an up-to-date version of browserstlist in my package.json but this was a real headache to understand what happened.

  • update ember-macro-helpers to latest
  • update engine node version to v8.*
  • update travisci configuration to run on node v8

@GreatWizard
Copy link
Contributor Author

Oops it's a duplicate of #312 ... I just see it

@jasonmit jasonmit changed the title Update ember-macro-helpers version to expose a recent one in dependency [BREAKING] Update ember-macro-helpers version to expose a recent one in dependency Aug 25, 2019
@jasonmit jasonmit changed the title [BREAKING] Update ember-macro-helpers version to expose a recent one in dependency [BREAKING] Update ember-macro-helpers version, drops Node 6 support Aug 25, 2019
@jasonmit jasonmit merged commit 4b56658 into adopted-ember-addons:master Aug 25, 2019
@jasonmit
Copy link
Collaborator

v8.0.0 was released, thanks!

@GreatWizard GreatWizard deleted the update-ember-macro-helpers branch August 26, 2019 10:38
@GreatWizard
Copy link
Contributor Author

Thanks you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants