Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regarding-your-joss-submission #96

Closed
sandeshkatakam opened this issue Aug 25, 2023 · 4 comments
Closed

Regarding-your-joss-submission #96

sandeshkatakam opened this issue Aug 25, 2023 · 4 comments

Comments

@sandeshkatakam
Copy link

Link to the joss review issue :
openjournals/joss-reviews#5702
This issue is regarding your submission of the software paper BayesFlow to JOSS. I was trying to run the tests you mentioned in the tests folder using pytest. I am encountering the error because of the pyproject.toml file(this line in particular --cov BayesFlow). Can you please look into it once and respond.

@marvinschmitt
Copy link
Member

Thank you for opening this issue.

Could you please try to install pytest-cov for the coverage metrics and see whether that resolves the issue?

pip install pytest-cov

Thanks,
Marvin

@yannikschaelte
Copy link
Contributor

Hi @sandeshkatakam , the prerequisites for development should also be described here: https://bayesflow.org/contributing.html#environment

Specifically, running pip install -r requirements_dev.txt should install all necessary dependencies. @marvinschmitt it seems https://github.com/stefanradev93/BayesFlow/blob/Development/requirements_dev.txt could be updated, esp. to only require >= minimum versions?

@stefanradev93
Copy link
Contributor

I have updated requirements_dev.txt in Development to use at least the recent versions of the listed packages (>=) .

@sandeshkatakam
Copy link
Author

Thank you. The tests are running fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants