Make Hyper signatures conform to js-xdr changes.
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
commented
Jun 14, 2023
| @@ -28,14 +28,25 @@ exports[`.transform(type definitions) 1`] = ` | |||
| validateXDR(input: string, format: \\"hex\\" | \\"base64\\"): boolean; | |||
| } | |||
|
|
|||
| interface Bool { | |||
There was a problem hiding this comment.
this is from #4 because yarn test -u wasn't run
paulbellamy
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is contingent upon the release of js-xdr@3.0.0.
This modifies the constructor for
HyperandUnsignedHyperto match the new ways to create integers larger than 32-bits in stellar/js-xdr (see stellar/js-xdr#100):It also adds conversions methods to make it easier to use in native code:
Known Limitations
Because
dts-dom(the underlying workhorse of this package) does not supportbigintas a type (i.e. there was nodom.types.bigint), I forked it to a personal repo. We should probably make it a Stellar repo, instead.