Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] adds blockaid scan site service and route #99

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aristidesstaffieri
Copy link
Contributor

What
Adds Blockaid sdk, service, and route to scan sites

Why
To utilize in our connect dapp flow in order to flag suspicious sites

@stellar-jenkins
Copy link

Something went wrong with PR preview build please check

Copy link

socket-security bot commented Jul 2, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@blockaid/client@0.11.0 environment, network Transitive: filesystem +20 13.2 MB blockaiduser

View full report↗︎

Copy link

socket-security bot commented Jul 2, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Network access npm/node-fetch@2.7.0 🚫
Network access npm/node-fetch@2.7.0 🚫
Network access npm/node-fetch@2.7.0 🚫
Network access npm/agentkeepalive@4.5.0 🚫
Network access npm/agentkeepalive@4.5.0 🚫
Network access npm/@blockaid/client@0.11.0 🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/node-fetch@2.7.0
  • @SocketSecurity ignore npm/agentkeepalive@4.5.0
  • @SocketSecurity ignore npm/@blockaid/client@0.11.0

try {
const data = await this.blockAidClient.site.scan({ url });

if (data.status === "miss") {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add an explicit loop count to exit this because our fetch client will abort the request after 5 seconds. I was also thinking we may want to handle the misses out of the request lifecycle by making Freighter client poll another route which will check misses separately instead of keeping the request open like this does, thoughts?

@stellar-jenkins
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants