-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] adds blockaid scan site service and route #99
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
46e7b5b
adds blockaid scan site service and route
aristidesstaffieri 9ef0b89
adds blockaid mock in test helper
aristidesstaffieri 263ae53
removes retry on status miss
aristidesstaffieri e222f60
adds counter for scan misses
aristidesstaffieri 5a97bd9
adds register to blockaid references
aristidesstaffieri 10e3980
Merge branch 'release/1.4.3' into feature/blockaid-dapp-scan
aristidesstaffieri 29fc396
removes unused sentry reference
aristidesstaffieri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import Blockaid from "@blockaid/client"; | ||
| import { Logger } from "pino"; | ||
| import { ERROR } from "../../helper/error"; | ||
|
|
||
| export class BlockAidService { | ||
| blockAidClient: Blockaid; | ||
| logger: Logger; | ||
| constructor(blockAidClient: Blockaid, logger: Logger) { | ||
| this.blockAidClient = blockAidClient; | ||
| this.logger = logger; | ||
| } | ||
|
|
||
| scanDapp = async ( | ||
| url: string | ||
| ): Promise<{ | ||
| data: Blockaid.Site.SiteScanResponse | null; | ||
| error: string | null; | ||
| }> => { | ||
| try { | ||
| const data = await this.blockAidClient.site.scan({ url }); | ||
|
|
||
| if (data.status === "miss") { | ||
| return await this.scanDapp(url); | ||
| } | ||
|
|
||
| return { data, error: null }; | ||
| } catch (error) { | ||
| this.logger.error(error); | ||
| return { data: null, error: ERROR.UNABLE_TO_SCAN_SITE }; | ||
| } | ||
| }; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't add an explicit loop count to exit this because our fetch client will abort the request after 5 seconds. I was also thinking we may want to handle the misses out of the request lifecycle by making Freighter client poll another route which will check misses separately instead of keeping the request open like this does, thoughts?