horizon: meta should be returned as null rather than empty when SKIP_TXMETA enabled
#5221
Comments
|
To be released in 2.28.4 |
sreuland
added a commit
to sreuland/go
that referenced
this issue
Mar 4, 2024
7 tasks
sreuland
added a commit
to sreuland/go
that referenced
this issue
Mar 4, 2024
sreuland
added a commit
to sreuland/go
that referenced
this issue
Mar 4, 2024
sreuland
added a commit
to sreuland/go
that referenced
this issue
Mar 4, 2024
sreuland
added a commit
to sreuland/go
that referenced
this issue
Mar 5, 2024
…resource adapters instead of static dependency injection pattern
sreuland
added a commit
to sreuland/go
that referenced
this issue
Mar 6, 2024
…son mapping, so field is absent from json
sreuland
added a commit
to sreuland/go
that referenced
this issue
Mar 6, 2024
urvisavla
pushed a commit
that referenced
this issue
Mar 6, 2024
…abled (#5228) * #5221: fixed unit test for singleton usage of resourceadpater * #5221: updated changelogs on protocol and horizon * #5221: use functional composition to pass SKIP_TXMETA down to resource adapters instead of static dependency injection pattern * #5221: use empty string for result_meta_xdr and omitempty on json mapping, so field is absent from json * #5221: fixed client unit test
Shaptic
pushed a commit
to Shaptic/go
that referenced
this issue
Mar 12, 2024
…abled (stellar#5228) * stellar#5221: fixed unit test for singleton usage of resourceadpater * stellar#5221: updated changelogs on protocol and horizon * stellar#5221: use functional composition to pass SKIP_TXMETA down to resource adapters instead of static dependency injection pattern * stellar#5221: use empty string for result_meta_xdr and omitempty on json mapping, so field is absent from json * stellar#5221: fixed client unit test
Shaptic
pushed a commit
to Shaptic/go
that referenced
this issue
Mar 12, 2024
…abled (stellar#5228) * stellar#5221: fixed unit test for singleton usage of resourceadpater * stellar#5221: updated changelogs on protocol and horizon * stellar#5221: use functional composition to pass SKIP_TXMETA down to resource adapters instead of static dependency injection pattern * stellar#5221: use empty string for result_meta_xdr and omitempty on json mapping, so field is absent from json * stellar#5221: fixed client unit test
|
this went out in 2.29.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Original issue here #5189
Our original implementation of this had the API returning valid but empty metas. This seems to have been a miscommunication as the product request was for the API to return
null. We should update the API responses to return null rather than empty metas.The text was updated successfully, but these errors were encountered: