services/horizon: return null txmeta in api model when SKIP_TXMETA enabled #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreuland
commented
Mar 4, 2024
tamirms
reviewed
Mar 4, 2024
…resource adapters instead of static dependency injection pattern
tamirms
approved these changes
Mar 5, 2024
…son mapping, so field is absent from json
sreuland
added a commit
that referenced
this pull request
Mar 11, 2024
Shaptic
pushed a commit
to Shaptic/go
that referenced
this pull request
Mar 12, 2024
…abled (stellar#5228) * stellar#5221: fixed unit test for singleton usage of resourceadpater * stellar#5221: updated changelogs on protocol and horizon * stellar#5221: use functional composition to pass SKIP_TXMETA down to resource adapters instead of static dependency injection pattern * stellar#5221: use empty string for result_meta_xdr and omitempty on json mapping, so field is absent from json * stellar#5221: fixed client unit test
Shaptic
pushed a commit
to Shaptic/go
that referenced
this pull request
Mar 12, 2024
…abled (stellar#5228) * stellar#5221: fixed unit test for singleton usage of resourceadpater * stellar#5221: updated changelogs on protocol and horizon * stellar#5221: use functional composition to pass SKIP_TXMETA down to resource adapters instead of static dependency injection pattern * stellar#5221: use empty string for result_meta_xdr and omitempty on json mapping, so field is absent from json * stellar#5221: fixed client unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
When SKIP_TXMETA is enabled the api resource model for
Transaction.result_meta_xdrwill be set to null.Why
Closes #5221
prior work for eliding tx meta on SKIP_TXMETA for context - #5208
Known limitations
this will require a new horizon patch release 2.28.4
this will require a new go client sdk releast 0.16.0
To provide nullability on
Transaction.result_meta_xdr, had to make breaking change on Transaction resource model, this will require propagating the nullable aspect to other SDK's to handle potential null's.