xdr: Use underscore in JSON fields for claim predicate. #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
force-pushed
the
sneak-case-claim-predicate
branch
from
b8dc48a
to
764d8eb
Compare
bartekn
approved these changes
Oct 2, 2020
| @@ -42,7 +42,8 @@ const ( | |||
| // - 10: Fixes a bug in meta processing (fees are now processed before | |||
| // everything else). | |||
| // - 11: Protocol 14: CAP-23 and CAP-33. | |||
| CurrentVersion = 11 | |||
| // - 12: Update claim predicate JSON fields to use underscore instead of camel case. | |||
| CurrentVersion = 12 | |||
There was a problem hiding this comment.
Let's not do this. We can manually rebuild state with horizon expingest trigger-state-rebuild.
There was a problem hiding this comment.
You were right, this is better for end users: #3100.
abuiles
force-pushed
the
sneak-case-claim-predicate
branch
from
764d8eb
to
bfa6230
Compare
This was referenced Oct 2, 2020
Closed
bartekn
pushed a commit
that referenced
this pull request
Oct 5, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Use underscore in JSON fields for claim predicate.
Why
Horizon uses underscore for payload fields, this change updates JSON marshaling to use underscore.
Fixes #3079
Known limitations
[TODO or N/A]