Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js-stellar-base: update XDR to support fees #596

Closed
tsachiherman opened this issue May 3, 2023 · 4 comments
Closed

js-stellar-base: update XDR to support fees #596

tsachiherman opened this issue May 3, 2023 · 4 comments
Assignees
@sreuland
Labels
preview-9 soroban-scrum

Comments

@tsachiherman
Copy link

What ?

Update XDR to support fees

Epic

stellar/stellar-cli#519
@tsachiherman tsachiherman mentioned this issue May 3, 2023
Closed
@tsachiherman tsachiherman linked a pull request May 4, 2023 that will close this issue
xdr: update XDR #598
Closed
@sreuland sreuland self-assigned this May 5, 2023
sreuland added a commit that referenced this issue May 5, 2023
@sreuland
#596: updated to latest preview 9 soroban xdr defs, includes fees, mu…
77cdf69 
…lti-function invoke
@sreuland sreuland mentioned this issue May 5, 2023
Closed
sreuland added a commit that referenced this issue May 8, 2023
@sreuland
#596: set xdr gen to Preview 9 xdr commit
a3baf27
sreuland added a commit that referenced this issue May 8, 2023
@sreuland
#596: set xdr generated types to come from 'next'
cb984ce
sreuland added a commit that referenced this issue May 10, 2023
@sreuland
#596: added test coverage on multi-function invokeHostFunction operat…
093e437 
…ion builder
sreuland added a commit that referenced this issue May 11, 2023
@sreuland
#596: added exported type for Operation.invokeHostFunctions
3034398
@sreuland
Copy link
Contributor

PR - #604

sreuland added a commit that referenced this issue May 11, 2023
@sreuland
#596: added tests and docs, pr feedback
14cb998
@sreuland
Copy link
Contributor

moving this to blocked as dev and unit test complete, but tests are failing due a strange issue with the js xdr generation, investigating further on pr - #604 (comment)

@sreuland
Copy link
Contributor

found a work-around and moved #604 back to review.

@sreuland
Copy link
Contributor

#604 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sreuland sreuland

Labels
preview-9 soroban-scrum
Projects
Platform Scrum
Status: Done
Milestone
No milestone
3 participants
@mollykarcher @sreuland @tsachiherman