Replace Rakefile with Makefile #537
Conversation
|
Yeah, my plan for now for dev was to do a separate branch and switch it in there. "Proper" switching between the xdrs is tbd (any suggestions?), but figured backporting this would minimize the diff later. |
There was a problem hiding this comment.
Incidentally, this updated the curr xdr to latest core master. But could leave that out of this PR if desired.
If doing this is not inconvenient, could we leave that out of this PR so that this change is isolated to a refactor only, then follow up with another PR where we generate it?
Otherwise 👍🏻.
| Stellar-overlay.x \ | ||
| Stellar-transaction.x \ | ||
| Stellar-types.x | ||
| XDR_FILES_LOCAL_CURR=$(addprefix xdr/curr/,$(XDR_FILES_CURR)) |
There was a problem hiding this comment.
This whole curr and next thing broke the entire ecosystem, I bet. Why couldn't they keep xdr/ and add xdr-next/??
| cd .. && rm -rf dts-xdr | ||
| yarn run prettier --write types/xdr.d.ts | ||
| ``` | ||
| 1. Make sure you have [Docker](https://www.docker.com/) installed and running. |
There was a problem hiding this comment.
Better link: https://docs.docker.com/engine/install/
| @@ -7,7 +7,6 @@ | |||
| "scripts": { | |||
| "test": "gulp test:node", | |||
| "test:watch": "gulp test:watch", | |||
| "xdr": "bundle exec xdrgen -o src/generated -l javascript -n stellar-xdr xdr/Stellar-ledger-entries.x xdr/Stellar-ledger.x xdr/Stellar-overlay.x xdr/Stellar-SCP.x xdr/Stellar-transaction.x xdr/Stellar-types.x", | |||
There was a problem hiding this comment.
Why not add the make reset-xdr command here?
This does a few things:
Replace Rakefile with Makefile (to match https://github.com/stellar/rs-stellar-xdr).
Remove all ruby. Not needed anymore. xdrgen is dockerized
Automate and dockerize the dts-xdr build step.
Split
xdrdirectory intoxdr/currandxdr/next. Which one it uses is hard-coded insrc/xdr.jsandtypes/xdr.d.tsfor now.Cleaned up the readme for all of the above.
Incidentally, this updated the curr xdr to latest core master. But could leave that out of this PR if desired.
The main potential issue with this are our hand-edit hacks in the .d.ts files. So like.. make can re-generate those files, but... They'll be broken until you copy-pasta over the changes again. oof.