Add SEP0029 support for FeeBumpTransaction. #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ire-and-curses
approved these changes
Apr 27, 2020
This was referenced Apr 27, 2020
Closed
overcat
reviewed
Apr 28, 2020
| @@ -701,7 +707,13 @@ export class Server { | |||
| * requires a memo, the promise will throw {@link AccountRequiresMemoError}. | |||
| * @throws {AccountRequiresMemoError} | |||
| */ | |||
| public async checkMemoRequired(transaction: Transaction): Promise<void> { | |||
| public async checkMemoRequired( | |||
There was a problem hiding this comment.
Hi @abuiles, if the operation destination is an M.. address, can Horizon load it correctly? Or should we skip this single check?
https://github.com/stellar/js-stellar-sdk/pull/535/files#diff-916156c481141bfcd08c6ae40ce10e00R742
There was a problem hiding this comment.
@overcat that's a great question, I believe we should skip the check if the destination is an M address since M addresses essentially encode a memo within them
There was a problem hiding this comment.
@overcat good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle SEP0029 memo required check when sending a
FeeBumpTransaction.