Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency URIjs change to urijs #55

Merged
merged 4 commits into from
Jan 31, 2016
Merged

dependency URIjs change to urijs #55

merged 4 commits into from
Jan 31, 2016

Conversation

brianebert
Copy link
Contributor

Noticed deprecation warning when updating sdk

bartekn added a commit that referenced this pull request Jan 31, 2016
dependency URIjs change to urijs
@bartekn bartekn merged commit 24735fc into stellar:master Jan 31, 2016
@bartekn bartekn removed the in orbit label Jan 31, 2016
@brianebert
Copy link
Contributor Author

Hi Bartek,

Thank you for looking into this.  Can you confirm or instruct:

Did I follow procedure correctly by forking the master repo and submitting the pr from my fork?Are there any changes to procedure I should adopt?

Thanks for all your hard work.

Best regards,
Brian

On Jan 31, 2016, at 5:08 AM, Bartek Nowotarski notifications@github.com wrote:

Merged
#55.

Reply to this email directly or
view it on GitHub.

@bartekn
Copy link
Contributor

bartekn commented Feb 1, 2016

@brianebert you did everything correctly. The problem was on our side. Travis does not export encrypted env variables in PRs and we need a Sauce Labs key. It was fixed in: a7894fe.

@brianebert
Copy link
Contributor Author

Thanks for letting me know, and thanks for all of your hard work.

Brian


From: Bartek Nowotarski [notifications@github.com]
Sent: Monday, February 01, 2016 4:02 AM
To: stellar/js-stellar-sdk
Cc: Brian Ebert
Subject: Re: [js-stellar-sdk] dependency URIjs change to urijs (#55)

@brianeberthttps://github.com/brianebert you did everything correctly. The problem was on our side. Travis does not export encrypted env variables in PRs and we need a Sauce Labs key. It was fixed in: a7894fehttps://github.com/stellar/js-stellar-sdk/commit/a7894fe989f266792d7b602193d318492b29ed30.


Reply to this email directly or view it on GitHubhttps://github.com//pull/55#issuecomment-177939168.

lhtdeepaktomar pushed a commit to lhtdeepaktomar/js-stellar-sdk that referenced this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants