Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden library compatibility by transpiling Stellar dependencies #837

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented May 26, 2023

In line with stellar/js-soroban-client#88, stellar/js-soroban-client#75, and stellar/js-soroban-client#76, the modernization of the build pipeline has some unpleasant downstream impacts. This changeset should minimize that:

  • Babel will transpile our modern dependencies
  • TypeScript will only drop declaration files and keep comments

Copy link

@aristidesstaffieri aristidesstaffieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Shaptic Shaptic merged commit bb7f443 into master Jul 11, 2023
6 checks passed
@Shaptic Shaptic deleted the babelify-deps branch July 11, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants