Auth0 integration_V2 #703

ymatienzo · 2021-06-19T12:14:32Z

Updates based on Nikhil previous comments

…mand

…nto auth0-integration auth0-integration

nikhilsaraf

Thank you for updating the PR. Code looks good to me ! 🎉

Test was failing because of testnet reset and I've rerun it now and it's passing.

Going to download codebase once and run locally to ensure I haven't missed anything and we should be good to go!

nikhilsaraf · 2021-06-28T14:49:21Z

README.md

@@ -184,6 +185,11 @@ You can find more details on the [CCXT_REST github page][ccxt-rest].

 [Postgres][postgres] v12.1 or later must be installed for Kelp to automatically write trades to a sql database along with updating the trader config file.

+### Using Auth0
+
+A [auth0](https://auth0.com/) account is required. To use it, uncomment \[AUTH0] section in [Sample GUI config file](examples/configs/trader/sample_GUI_config.cfg) and enter your auth0 crendentials in required fields.


👍 thanks!

nikhilsaraf · 2021-06-28T14:53:30Z

examples/configs/trader/sample_GUI_config.cfg

+# Sample UI config file for the kelp bot
+
+# uncomment the AUTH0 section below to enable
+# [AUTH0]


nikhilsaraf · 2021-06-28T15:05:27Z

gui/backend/jwt_middleware.go

+
+		cert, err := getPemCert(token)
+		if err != nil {
+			return nil, fmt.Errorf("error when getting PEM certificate: %s", err)


nikhilsaraf · 2021-06-28T15:07:11Z

gui/backend/routes.go

+		var router chi.Router = r
+		if s.guiConfig.Auth0Config != nil && s.guiConfig.Auth0Config.Auth0Enabled {
+			// setting the router to use the JWT middleware to handle auth0 style JWT tokens
+			router = r.With(JWTMiddlewareVar.Handler)


much better, thank you!! 💯 🎉

nikhilsaraf · 2021-06-28T15:09:13Z

gui/backend/serverMetadata.go

 }

 func (s *APIServer) serverMetadata(w http.ResponseWriter, r *http.Request) {
 	metadata := ServerMetadataResponse{
 		DisablePubnet: s.disablePubnet,
 		EnableKaas:    s.enableKaas,
+		GuiConfig:	   s.guiConfig,


perfect! 👍

nikhilsaraf · 2021-06-28T15:10:22Z

gui/backend/api_server.go

@@ -59,6 +60,7 @@ type APIServer struct {
 	kelpErrorsByUserLock *sync.Mutex

 	cachedOptionsMetadata metadata
+	guiConfig			guiconfig.GUIConfig


nikhilsaraf · 2021-06-28T15:15:10Z

gui/web/src/kelp-ops-api/serverMetadata.js

@@ -1,5 +1,5 @@
 export default (baseUrl) => {
-    return fetch(baseUrl + "/api/v1/serverMetadata").then(resp => {
+    return fetch(baseUrl + "/api/v1/serverMetadata", {method: "GET"}).then(resp => {


I thought the default is GET if left unspecified; we leave it unspecified when invoking other GET endpoints like /version and /newSecretKey. But this is ok, so can leave as-is. Thanks!

so the thing with interceptor is, it overrides the header on every request, so when we make a fetch request it looks for header, but in this case, it was unable to find it so I deliberately added {method: "GET"} in fetch request to have a valid header to override.

Ran into this issue while running in kaas mode in my local copy.
/newSecretKey (newSecretKey.js) fails in the interceptor because this config isn't specified. Ideally we shouldn't have to specify this since it's optional in the fetch API which defaults to using a GET method.

Can we try by adding a null check to config in the interceptor rather than just checking if config.headers is null?

nikhilsaraf · 2021-06-28T15:21:24Z

gui/web/src/App.js

@@ -372,7 +383,18 @@ class App extends Component {
        <Welcome quitFn={this.quit} showQuitButton={this.showQuitButton()}/>
      </div>
    );
+
+    return (<div>


glad this finally worked. thanks!

nikhilsaraf · 2021-06-28T15:24:25Z

cmd/server_amd64.go

@@ -382,6 +413,7 @@ func init() {
 			*options.noHeaders,
 			quit,
 			metricsTracker,
+			auth0ConfigVar,


thanks for fitting into the existing serverMetadata pattern! 🎉

nikhilsaraf

Think I found only one issue while testing locally -- the issue with the {method: GET}, commented inline.

Should be good to merge once we figure that out. This is coming together quite nicely!!

nikhilsaraf · 2021-06-28T20:00:00Z

gui/web/src/kelp-ops-api/serverMetadata.js

@@ -1,5 +1,5 @@
 export default (baseUrl) => {
-    return fetch(baseUrl + "/api/v1/serverMetadata").then(resp => {
+    return fetch(baseUrl + "/api/v1/serverMetadata", {method: "GET"}).then(resp => {


Ran into this issue while running in kaas mode in my local copy.
/newSecretKey (newSecretKey.js) fails in the interceptor because this config isn't specified. Ideally we shouldn't have to specify this since it's optional in the fetch API which defaults to using a GET method.

Can we try by adding a null check to config in the interceptor rather than just checking if config.headers is null?

nikhilsaraf · 2021-06-28T20:12:04Z

PS: created an issue for this task here: #706, for when we merge this in to the master branch tomorrow!

updated interceptor to create a new header for a request which doesn't have one.

reverted back the changes to this file.

reverted this file back to its original state

nikhilsaraf

LGTM, thanks! 🎉

sanjsingh07 and others added 21 commits April 11, 2021 17:08

add separate auth0 file for beckend

85f5785

revert commit

d289150

Merge branch 'master' of https://github.com/stellar/kelp

b6029ff

configured auth0 on GUI

9b75668

added interceptor

eb09550

added support for accepting GUI config file through CLI on server com…

4c75879

…mand

fixed not rendering component on async token call

93a94df

finalize Auth0 Implementation

c378e9e

removed unused code

eb6574b

fixing xdg-open not found bug on some linux-machine

ef1b06b

trying to fix continuous reloading issue when deploying on k8s

96fad7b

auth0-implemention

c325878

auth0-implemention

65499e7

updated readme.md

0584f93

Merge branch 'master' of https://github.com/stellar/kelp

939863e

Merge branch 'auth0-integration' of https://github.com/orunpay/kelp i…

5002d86

…nto auth0-integration auth0-integration

auth0-integration

1d182dd

Delete auth0-config.json

157408c

Auth0 Implementation

4120425

Merge branch 'master' of https://github.com/orunpay/kelp

8b3b33a

Auth0 integration V2

3b55fbd

ymatienzo requested a review from nikhilsaraf as a code owner June 19, 2021 12:14

nikhilsaraf reviewed Jun 28, 2021

View reviewed changes

sanjsingh07 added 3 commits June 29, 2021 18:16

Updated interceptor.js

9f721e0

updated interceptor to create a new header for a request which doesn't have one.

Update serverMetadata.js

aecf3e4

reverted back the changes to this file.

Update version.js

26fdb7d

reverted this file back to its original state

nikhilsaraf approved these changes Jun 30, 2021

View reviewed changes

nikhilsaraf merged commit 6b30fa2 into stellar-deprecated:master Jun 30, 2021

sanjsingh07 mentioned this pull request Sep 25, 2023

Verification BTCMedia/B24-Open-Source-Program#341

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auth0 integration_V2 #703

Auth0 integration_V2 #703

ymatienzo commented Jun 19, 2021

nikhilsaraf left a comment

nikhilsaraf Jun 28, 2021

nikhilsaraf Jun 28, 2021

nikhilsaraf Jun 28, 2021

nikhilsaraf Jun 28, 2021

nikhilsaraf Jun 28, 2021

nikhilsaraf Jun 28, 2021

nikhilsaraf Jun 28, 2021

sanjsingh07 Jun 28, 2021

nikhilsaraf Jun 28, 2021

nikhilsaraf Jun 28, 2021

nikhilsaraf Jun 28, 2021

nikhilsaraf left a comment

nikhilsaraf Jun 28, 2021

nikhilsaraf commented Jun 28, 2021 •

edited

Loading

nikhilsaraf left a comment

Auth0 integration_V2 #703

Auth0 integration_V2 #703

Conversation

ymatienzo commented Jun 19, 2021

nikhilsaraf left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikhilsaraf left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikhilsaraf commented Jun 28, 2021 • edited Loading

nikhilsaraf left a comment

Choose a reason for hiding this comment

nikhilsaraf commented Jun 28, 2021 •

edited

Loading