Merge github.com/stellar/rs-soroban-sdk #308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to merge this with a merge commit, but annoying GitHub won't let me do that. |
|
This PR appears to not preserve history of the original tree as well as I had hoped, I'll have to have another crack at it. |
|
After talking with @tomerweller and @ire-and-curses, some things said has changed my mind about chasing this. I think we do need some separation of process between the env and sdk repos. And while a decent amount of the SDK lives in the env-common crate, it is more static, less likely to change, and we can use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Merge github.com/stellar/rs-soroban-sdk
Why
Much of the sdk lives in env-common, and we seem to be constantly developing both in conjunction. It feels artificial that they live in separate repos.