Remove soroban-spec-tools #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
commented
Feb 26, 2024
Comment on lines
-1013
to
+1011
| }) => Ok( | ||
| contract::Spec::new(&self.get_remote_wasm_from_hash(hash).await?) | ||
| .map_err(Error::CouldNotParseContractSpec)? | ||
| .spec, | ||
| ), | ||
| }) => Ok(soroban_spec::read::from_wasm( | ||
| &self.get_remote_wasm_from_hash(hash).await?, | ||
| )?), |
There was a problem hiding this comment.
This is the main part of the change. The soroban-spec crate already provides the same functionality that the soroban-spec-tools crate wraps and adds additional CLI related functionality to. There's no need for the RPC to use the soroban-spec-tools crate for this as it doesn't need the CLI related functionality.
10 tasks
|
The Go linter check is failing, but this PR doesn't touch the Go code. |
psheth9
approved these changes
Feb 27, 2024
Comment on lines
-1013
to
+1011
| }) => Ok( | ||
| contract::Spec::new(&self.get_remote_wasm_from_hash(hash).await?) | ||
| .map_err(Error::CouldNotParseContractSpec)? | ||
| .spec, | ||
| ), | ||
| }) => Ok(soroban_spec::read::from_wasm( | ||
| &self.get_remote_wasm_from_hash(hash).await?, | ||
| )?), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove soroban-spec-tools.
Why
The soroban-spec-tools crate primarily exists to support the CLI. It contains logic that originally existed in the CLI and was separated into a library.
The soroban-rpc is using one function of the crate, but actually that function is just a call through to the soroban-spec crate. There's no need for the soroban-rpc to depend on the other logic in the soroban-spec-tools crate and it is inconvenient that it does.
It's inconvenient because the soroban-spec-tools crate is closely coupled with the soroban-cli, and changes to both of those together are more likely than changes to the rpc and it.
This came up when I tried to change the output of the soroban-cli, and to change the output of the cli I need to change the soroban-spec-tools crate.
This PR should be accompanied by another PR that moves the soroban-spec-tools crate back to the soroban-tools/cli repo.
Related: