Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "CRITICAL" quality validators #2247

Closed
MonsieurNicolas opened this issue Aug 22, 2019 · 3 comments · Fixed by #2277
Closed

Add support for "CRITICAL" quality validators #2247

MonsieurNicolas opened this issue Aug 22, 2019 · 3 comments · Fixed by #2277
Assignees
Projects

Comments

@MonsieurNicolas
Copy link
Contributor

Right now we have HIGH, MEDIUM, LOW.

Even HIGH only enforces 67% threshold - we should add a CRITICAL quality level that when causes entities in that level to be required (threshold of that group is 100%).

There are many uses cases for this, one of them is to require that a node from an organization agrees to other nodes in the same organization.

This change will require increasing the maximum allowed nesting level as well.

@MonsieurNicolas MonsieurNicolas added this to To do in v12.0.0 via automation Aug 22, 2019
@MonsieurNicolas MonsieurNicolas removed this from To do in v12.0.0 Sep 11, 2019
@MonsieurNicolas MonsieurNicolas added this to To do in v12.1.0 via automation Sep 11, 2019
@sisuresh
Copy link
Contributor

@MonsieurNicolas Can you please explain what "maximum allowed nesting level" means?

@MonsieurNicolas
Copy link
Contributor Author

a quorum set is a recursive data structure: it's how many recursions we can have.
See #2233 (where I increased it to handle HIGH + MEDIUM + LOW in the same quorum set)

@sisuresh
Copy link
Contributor

@MonsieurNicolas Right now, regardless of quality, it looks like the innerSets (homeDomain level) have a threshold of >50%, and the set above will have a threshold of ~67%.

With this Critical quality level, should the innerSet threshold be 100%, with the set above still set to ~67%, or should the above set also be 100%? I think the above should be 67%, but wanted to clarify.

@MonsieurNicolas MonsieurNicolas moved this from To do to In progress in v12.1.0 Sep 20, 2019
v12.1.0 automation moved this from In progress to Done Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v12.1.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants