Added Critical Quality level #2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisuresh
force-pushed
the
issue-2247-AddCriticalQuality
branch
from
d9cab5c
to
0595d34
Compare
MonsieurNicolas
requested changes
Sep 24, 2019
| @@ -40,38 +40,6 @@ static const std::unordered_set<std::string> TESTING_ONLY_OPTIONS = { | |||
| static const std::unordered_set<std::string> TESTING_SUGGESTED_OPTIONS = { | |||
| "ALLOW_LOCALHOST_FOR_TESTING"}; | |||
|
|
|||
| namespace | |||
There was a problem hiding this comment.
avoid moving code if you don't have to
| @@ -172,25 +172,30 @@ TEST_CASE("sane quorum set", "[scp][quorumset]") | |||
| check(qSet, true, qSelfSet); | |||
| } | |||
|
|
|||
| SECTION("{ t: 1, v0, { t: 1, v1, { t: 1, v2, { t: 1, v3 , { t: 1, v4} } } " | |||
| SECTION("{ t: 1, v0, { t: 1, v1, { t: 1, v2, { t: 1, v3 , { t: 1, v4, { t: " | |||
There was a problem hiding this comment.
forgot to update config test "load validators config"
| @@ -32,8 +32,17 @@ class Config : public std::enable_shared_from_this<Config> | |||
| { | |||
| VALIDATOR_LOW_QUALITY = 0, | |||
| VALIDATOR_MED_QUALITY = 1, | |||
| VALIDATOR_HIGH_QUALITY = 2 | |||
| VALIDATOR_HIGH_QUALITY = 2, | |||
There was a problem hiding this comment.
forgot to update documentation in docs/stellar-core_example.cfg (where QUALITY is mentioned)
There was a problem hiding this comment.
forgot to update kQualities (so CRITICAL cannot be parsed at all)
| @@ -1411,7 +1384,9 @@ Config::generateQuorumSetHelper( | |||
| "High quality validator {} must have redundancy of at least 3", | |||
| it->mName)); | |||
| } | |||
| innerSet.threshold = computeDefaultThreshold(innerSet, true); | |||
| innerSet.threshold = computeDefaultThreshold( | |||
There was a problem hiding this comment.
CRITICAL is better than HIGH, so we should require at least 3 validators at that quality level
sisuresh
force-pushed
the
issue-2247-AddCriticalQuality
branch
from
0595d34
to
1d34aaa
Compare
MonsieurNicolas
requested changes
Sep 25, 2019
| "} } -> too deep") | ||
| { | ||
| auto qSet = makeSingleton(keys[0]); | ||
| auto qSet1 = makeSingleton(keys[1]); | ||
| auto qSet2 = makeSingleton(keys[2]); | ||
| auto qSet3 = makeSingleton(keys[3]); | ||
| auto qSet4 = makeSingleton(keys[4]); | ||
| auto qSet5 = makeSingleton(keys[5]); |
There was a problem hiding this comment.
this test update belongs to the other commit
sisuresh
force-pushed
the
issue-2247-AddCriticalQuality
branch
from
1d34aaa
to
24b0bab
Compare
|
r+ 24b0bab |
latobarita
added a commit
that referenced
this pull request
Oct 2, 2019
Added Critical Quality level Reviewed-by: MonsieurNicolas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2247
Added a Critical Quality level that will require 100% of the groups at that level to come to consensus.
Checklist
clang-formatv5.0.0 (viamake formator the Visual Studio extension)