Hash x #1097
Closed
Hash x #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
jedmccaleb
reviewed
Dec 14, 2016
| @@ -0,0 +1,92 @@ | |||
| // Copyright 2016 Stellar Development Foundation and contributors. Licensed | |||
jedmccaleb
reviewed
Dec 14, 2016
| auto &hashXKeyWeights = signers[SIGNER_KEY_TYPE_HASH_X]; | ||
| for (size_t i = 0; i < mSignatures.size(); i++) | ||
| { | ||
| auto x = std::string{mSignatures[i].signature.begin(), mSignatures[i].signature.end()}; |
There was a problem hiding this comment.
Is the preimage a string?
There was a problem hiding this comment.
using just mSignatures[i].signature now
jedmccaleb
reviewed
Dec 14, 2016
| @@ -327,16 +328,13 @@ PubKeyUtils::verifySig(PublicKey const& key, Signature const& signature, | |||
| SignatureHint | |||
| PubKeyUtils::getHint(PublicKey const& pk) | |||
There was a problem hiding this comment.
Just have people call SignatureUtils::getHint directly if you want to move this function there.
jedmccaleb
reviewed
Dec 14, 2016
| SignatureHint res; | ||
| memcpy(res.data(), &pk.ed25519().back() - res.size() + 1, res.size()); | ||
| return res; | ||
| return SignatureUtils::getHint(pk.ed25519()); | ||
| } | ||
|
|
||
| bool | ||
| PubKeyUtils::hasHint(PublicKey const& pk, SignatureHint const& hint) |
There was a problem hiding this comment.
This seems misnamed. Seems like it should be called doesHintMatch or something
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Signed-off-by: Rafał Malinowski <rafal.przemyslaw.malinowski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #846