New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hash x #1097
Closed
Closed
Hash x #1097
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
132b060
hash(tx) is not a pubkey
vogel 739dd60
extracted SignatureChecker class
vogel e915e94
implement hash(x) signing
vogel 2b8cc84
test hash(x) signing
vogel 13abcb6
remove duplication from SignatureChecker
vogel 111ce8e
remove duplication from TxEnvelopeTests
vogel 93d6b1b
add tests for SignatureUtils
vogel 8d9e4c8
add more generic versions of getHint and hasHint
vogel b1999c4
use signature hint also for hash(x)
vogel 78551ac
do not assume 'x' in hash x is a valid string
vogel 10dccb6
rename hasHint to doesHintMatch
vogel 4302168
remove unneeded functions from PubKeyUtils
vogel File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ | |
#include "util/HashOfHash.h" | ||
#include <mutex> | ||
#include "main/Config.h" | ||
#include "transactions/SignatureUtils.h" | ||
#include "util/lrucache.hpp" | ||
|
||
namespace stellar | ||
|
@@ -327,16 +328,13 @@ PubKeyUtils::verifySig(PublicKey const& key, Signature const& signature, | |
SignatureHint | ||
PubKeyUtils::getHint(PublicKey const& pk) | ||
{ | ||
SignatureHint res; | ||
memcpy(res.data(), &pk.ed25519().back() - res.size() + 1, res.size()); | ||
return res; | ||
return SignatureUtils::getHint(pk.ed25519()); | ||
} | ||
|
||
bool | ||
PubKeyUtils::hasHint(PublicKey const& pk, SignatureHint const& hint) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems misnamed. Seems like it should be called There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. renamed |
||
{ | ||
return memcmp(&pk.ed25519().back() - hint.size() + 1, hint.data(), | ||
hint.size()) == 0; | ||
return SignatureUtils::hasHint(pk.ed25519(), hint); | ||
} | ||
|
||
PublicKey | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have people call SignatureUtils::getHint directly if you want to move this function there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed