CAP-0024 #2269
Merged
CAP-0024 #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
MonsieurNicolas
requested changes
Sep 11, 2019
MonsieurNicolas
requested changes
Sep 17, 2019
| destination, xlm, amount, xlm, 1, {}), | ||
| ex_PATH_PAYMENT_STRICT_SEND_MALFORMED); | ||
| // clang-format off | ||
| market.requireBalances( |
There was a problem hiding this comment.
(reminder for later) in general, we should leverage the invariant from applyCheck that only specific changes can be made on failure
| @@ -75,6 +75,56 @@ assetPathToString(const std::deque<Asset>& assets) | |||
| } | |||
| return r; | |||
| }; | |||
|
|
|||
| void | |||
| checkClaimedOffers(std::vector<ClaimOfferAtom> const& actual, | |||
|
@MonsieurNicolas squashed and rebased. |
|
r+ c7283b9 |
latobarita
added a commit
that referenced
this pull request
Sep 18, 2019
CAP-0024 Reviewed-by: MonsieurNicolas
This was referenced Sep 23, 2019
This was referenced Sep 23, 2019
This was referenced Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements CAP-0024, which introduces the new operation
PathPaymentStrictSend.Checklist
clang-formatv5.0.0 (viamake formator the Visual Studio extension)