Some more perf improvements #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonsieurNicolas
force-pushed
the
perfImprovements2
branch
from
646d225
to
5122be6
Compare
MonsieurNicolas
force-pushed
the
perfImprovements2
branch
from
5122be6
to
b7dd10a
Compare
|
changed "multi order book" to not use |
jonjove
suggested changes
Oct 12, 2021
| mChild->forAllWorstBestOffers( | ||
| [&](Asset const& buying, Asset const& selling, | ||
| std::shared_ptr<OfferDescriptor const>& desc) { | ||
| updateWorstBestOffer(AssetPair{buying, selling}, desc); |
There was a problem hiding this comment.
I commented earlier about avoiding the copy. I think this one is less scary than the previous one, because OfferDescriptors should never leak out of LedgerTxn. But we should make sure we understand what safety is being sacrificed.
MonsieurNicolas
commented
Oct 13, 2021
|
Looks good to me, please squash when you get a chance. @sisuresh I remember you had planned to review this as well, have you done so? |
safe to do: function cannot fail and child is invalidated
remove use of multimap
MonsieurNicolas
force-pushed
the
perfImprovements2
branch
from
36d1a07
to
6ac102f
Compare
|
r+ 6ac102f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up PR from #3180 this time focusing on performance while replaying transactions.
On my laptop the changes yield a 25% speed improvement (real time), broken down as follows:
noexcept. HistoricallyLedgerTxnwas written in an exception safe way, but we eventually added handlers to just crash in certain scenarios. There are no real benefits of allowing those functions to throw in other situations, as a result we can perform operations that are irreversible. See the next commitInternalLedgerKey. ~4% speed improvement. We could probably take this idea further, there are other places where we useLedgerKeyas key (that could benefit from this change)mActivewhen callingupdateEntry. 10% speed improvement. In most situations we already know if the key is active, so we can just call the right function.