Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate w/ SEP-8 server for "Action Required" transactions #113

Closed
marcelosalloum opened this issue Mar 9, 2021 · 1 comment · Fixed by #164
Closed

Integrate w/ SEP-8 server for "Action Required" transactions #113

marcelosalloum opened this issue Mar 9, 2021 · 1 comment · Fixed by #164
Assignees
Labels

Comments

@marcelosalloum
Copy link
Contributor

No description provided.

@marcelosalloum marcelosalloum self-assigned this Mar 9, 2021
marcelosalloum added a commit that referenced this issue May 24, 2021
### What

Support SEP-8 "Action Required" flow.

Closes #113 

### Future Work

The action fields received in the action required responses are all being handled as strings for now. I'll update this behavior to accept different kinds of inputs in the future, since the [SEP-9] field types can include "string", "country code", "phone number", date", "number" or "binary".

[SEP-9]: https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0009.md

### Screenshot

https://user-images.githubusercontent.com/1952597/119165154-958bd600-ba33-11eb-9639-3d014c8003d4.mov

### How to test

Use the jenkins preview link with `/account?secretKey=SBQZPYFQNQD4B7MP7PC3NKCMS5G5LD6PVO7BUYC34M4BBFN6KCXSKSVD` and send a small payment to `GBID36ML6VVNPIF6SQATQW5QIBREQAVEHQIUMWDLQCSVIYX2IJGK4KPP`.

#### KYC Approval Criteria

* Emails starting with "x" will get rejected
* Emails not starting with "x" will get approved.

If you need to repeat your tests you might need to delete the KYC already stored in the server with:
```curl
curl -X DELETE https://sep8-server.dev.stellar.org/kyc-status/GASA5HCKMDAPLB6NIV7ADDA6YMTAQ2555TXKMS7FSVO44TJXHEGXLICZ
```
@marcelosalloum
Copy link
Contributor Author

Closed by #164.

marcelosalloum added a commit that referenced this issue Jul 19, 2021
### What

Support SEP-8 "Action Required" flow.

Closes #113 

### Future Work

The action fields received in the action required responses are all being handled as strings for now. I'll update this behavior to accept different kinds of inputs in the future, since the [SEP-9] field types can include "string", "country code", "phone number", date", "number" or "binary".

[SEP-9]: https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0009.md

### Screenshot

https://user-images.githubusercontent.com/1952597/119165154-958bd600-ba33-11eb-9639-3d014c8003d4.mov

### How to test

Use the jenkins preview link with `/account?secretKey=SBQZPYFQNQD4B7MP7PC3NKCMS5G5LD6PVO7BUYC34M4BBFN6KCXSKSVD` and send a small payment to `GBID36ML6VVNPIF6SQATQW5QIBREQAVEHQIUMWDLQCSVIYX2IJGK4KPP`.

#### KYC Approval Criteria

* Emails starting with "x" will get rejected
* Emails not starting with "x" will get approved.

If you need to repeat your tests you might need to delete the KYC already stored in the server with:
```curl
curl -X DELETE https://sep8-server.dev.stellar.org/kyc-status/GASA5HCKMDAPLB6NIV7ADDA6YMTAQ2555TXKMS7FSVO44TJXHEGXLICZ
```
marcelosalloum added a commit that referenced this issue Jul 19, 2021
### What

Support SEP-8 "Action Required" flow.

Closes #113 

### Future Work

The action fields received in the action required responses are all being handled as strings for now. I'll update this behavior to accept different kinds of inputs in the future, since the [SEP-9] field types can include "string", "country code", "phone number", date", "number" or "binary".

[SEP-9]: https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0009.md

### Screenshot

https://user-images.githubusercontent.com/1952597/119165154-958bd600-ba33-11eb-9639-3d014c8003d4.mov

### How to test

Use the jenkins preview link with `/account?secretKey=SBQZPYFQNQD4B7MP7PC3NKCMS5G5LD6PVO7BUYC34M4BBFN6KCXSKSVD` and send a small payment to `GBID36ML6VVNPIF6SQATQW5QIBREQAVEHQIUMWDLQCSVIYX2IJGK4KPP`.

#### KYC Approval Criteria

* Emails starting with "x" will get rejected
* Emails not starting with "x" will get approved.

If you need to repeat your tests you might need to delete the KYC already stored in the server with:
```curl
curl -X DELETE https://sep8-server.dev.stellar.org/kyc-status/GASA5HCKMDAPLB6NIV7ADDA6YMTAQ2555TXKMS7FSVO44TJXHEGXLICZ
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant