SEP-31: add description explaining the premise of demo-ing SEP-31 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelosalloum
changed the title
leighmcculloch
approved these changes
Jun 4, 2021
| the public and secret keys don't represent the Sending Client but instead the | ||
| Sending Anchor's account. In SEP-31, the only Stellar transaction happening is | ||
| between the Sending and the Receiving anchors._ | ||
|
|
There was a problem hiding this comment.
Is there anything we can do to make this clearer in the UI too? I know personally that I'm likely to miss a note like this and make the wrong assumptions in the UI.
There was a problem hiding this comment.
Good idea, I can add a tooltip to description in the UI!
There was a problem hiding this comment.
Done in 7846ed0 and updated the PR description with a screenshot.
|
Preview is available here: |
marcelosalloum
changed the title
|
Preview is available here: |
leighmcculloch
approved these changes
Jun 4, 2021
JakeUrban
approved these changes
Jun 4, 2021
marcelosalloum
added a commit
that referenced
this pull request
Jul 19, 2021
### What Add description explaining the Demo Wallet keypair represents the Sending Anchor when we're demo-ing SEP-31. Added to Readme.md and to the SEP-31 modal. ### Why In all other use cases for the Demo Wallet, the keypair actually represents a client's account, SEP-31 is the only exception.
marcelosalloum
added a commit
that referenced
this pull request
Jul 19, 2021
### What Add description explaining the Demo Wallet keypair represents the Sending Anchor when we're demo-ing SEP-31. Added to Readme.md and to the SEP-31 modal. ### Why In all other use cases for the Demo Wallet, the keypair actually represents a client's account, SEP-31 is the only exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add description explaining the Demo Wallet keypair represents the Sending Anchor when we're demo-ing SEP-31. Added to Readme.md and to the SEP-31 modal.
Why
In all other use cases for the Demo Wallet, the keypair actually represents a client's account, SEP-31 is the only exception.
Screenshot