Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-31: add description explaining the premise of demo-ing SEP-31 #179

Merged
merged 2 commits into from
Jun 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ You can use the demo wallet to test Regulated Assets ([SEP-8]), Hosted Deposit a
9. Leave the pop-up window open while you wait to see the deposit of SRT go through - you can close when you see “Status” is complete and you have SRT.

### Demo-ing Cross-Border Payments ([SEP-31]) on Testnet

_Note: specifically in the case of demo-ing SEP-31 in the Demo Wallet, notice
the public and secret keys don't represent the Sending Client but instead the
Sending Anchor's account. In SEP-31, the only Stellar transaction happening is
between the Sending and the Receiving anchors._

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything we can do to make this clearer in the UI too? I know personally that I'm likely to miss a note like this and make the wrong assumptions in the UI.

Copy link
Contributor Author

@marcelosalloum marcelosalloum Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I can add a tooltip to description in the UI!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 7846ed0 and updated the PR description with a screenshot.

1. Follow the steps above in order to establish an amount of SRT to send.
2. Select “SEP-31 Send” from the dropdown for your SRT asset and click "Start" in the modal.
3. Enter the requested information in the pop-up - none of the info has to be real for this testanchor.stellar.org demo, this is only to show the fields required. When testing another anchor you may need to adhere to their validation requirements.
Expand Down
11 changes: 9 additions & 2 deletions src/components/Balance.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -175,14 +175,21 @@ export const Balance = ({
callback: () => handleSep24Withdraw(balance),
};
break;
case AssetActionId.SEP31_SEND:
case AssetActionId.SEP31_SEND: {
let description = `Start SEP-31 send to ${balance.assetCode}?\n\n`;
description +=
"Please be aware that specifically in the case of demo-ing SEP-31 in the Demo Wallet the public and secret keys don't represent the Sending Client but instead the Sending Anchor's account.\n\n";
description +=
"In SEP-31, the only Stellar transaction happening is between the Sending and the Receiving anchors.";
props = {
...defaultProps,
title: `SEP-31 send ${balance.assetCode}`,
description: `Start SEP-31 send to ${balance.assetCode}?`,

description,
callback: () => handleSep31Send(balance),
};
break;
}
default:
// do nothing
}
Expand Down
4 changes: 4 additions & 0 deletions src/components/Modal/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@
.InfoBlock:not(:last-child) {
margin-bottom: 1.5rem;
}

p {
white-space: pre-line;
}
}
}

Expand Down