Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code snippets in LP example docs #211

Closed
briwylde08 opened this issue Aug 14, 2023 · 3 comments
Closed

Update code snippets in LP example docs #211

briwylde08 opened this issue Aug 14, 2023 · 3 comments
Assignees
@ElliotFriend
Labels
bug Something isn't working

Comments

@briwylde08
Copy link
Contributor

Users are encountering errors when going through the Examples on this page: https://developers.stellar.org/docs/encyclopedia/liquidity-on-stellar-sdex-liquidity-pools#examples.

We need to update code snippets to avoid further errors. See specific conversation here: https://discord.com/channels/897514728459468821/907476473739354153/1137130480454610964
@briwylde08 briwylde08 added the bug Something isn't working label Aug 14, 2023
@ElliotFriend
Copy link
Contributor

Working on resolving this week. In the meantime:

A working script can be pieced together using the code examples from Stellar Quest, Level 3, Quest 5. Note that the runkit at the bottom of the page is intentionally not a "ready-to-run" script. However, if you put together all the snippets throughout the code instructions, you should get something that "works."

@ElliotFriend
Copy link
Contributor

It also appears the python code snippets on that docs page are still working

ElliotFriend added a commit to ElliotFriend/stellar-docs that referenced this issue Aug 22, 2023
@ElliotFriend
fix(examples): Fix JavaScript example on liquidity encyclopedia page
e200612 
The JavaScript example demonstrating how to create/deposit/withdraw
from a liquidity pool was a bit outdated, and needed some fixing to
get it working with the current stellar-sdk.

Refs: stellar#211
@ElliotFriend ElliotFriend mentioned this issue Aug 22, 2023
Merged
@ElliotFriend
Copy link
Contributor

For anyone following, PR #214 contains the fixes for the JS snippets. The preview is available here: https://developers-pr214.previews.kube001.services.stellar-ops.com/docs/encyclopedia/liquidity-on-stellar-sdex-liquidity-pools#examples

If you want to see/use the whole script in one "chunk" it's posted on runkit here: https://runkit.com/elliotfriend/64e4dab3a5dd27000801ffdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElliotFriend ElliotFriend

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ElliotFriend @briwylde08