Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): Fix JavaScript example on liquidity encyclopedia page #214

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

ElliotFriend
Copy link
Contributor

The JavaScript example demonstrating how to create/deposit/withdraw from a liquidity pool was a bit outdated, and needed some fixing to get it working with the current stellar-sdk.

Refs: #211

The JavaScript example demonstrating how to create/deposit/withdraw
from a liquidity pool was a bit outdated, and needed some fixing to
get it working with the current stellar-sdk.

Refs: stellar#211
@ElliotFriend
Copy link
Contributor Author

I updated the js script sections and left them in-place in the page. If anybody wants to see/use the whole script, you can find it in this runkit: https://runkit.com/elliotfriend/64e4dab3a5dd27000801ffdf

@stellar-jenkins
Copy link

Copy link
Contributor

@kalepail kalepail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've run the code and it all works fine it's gtg on my side

@ElliotFriend ElliotFriend merged commit 8635a31 into stellar:main Aug 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants