SEP-24: Added refunded transaction status

[lijamie98]

Since the refunded flag is being deprecated, MGI requested the refunded status.

[leighmcculloch]

One change request, otherwise looks good to me. cc @JakeUrban could you also 👀?

[leighmcculloch]

Since this is a new feature, the addition of a new status, this should be a minor version bump. Reserve patch version bumps for bug fixes.

Suggested change

	Version 2.3.1
	Version 2.4.0

[lijamie98]

Updated and pushed.

[CassioMG]

LGTM

[JakeUrban]

🤔 what is the relationship between refunded and completed_at? Can we also add a note to the deprecated refunded attribute that there is a transaction status for this now?

[lijamie98]

🤔 what is the relationship between refunded and completed_at? Can we also add a note to the deprecated refunded attribute that there is a transaction status for this now?

Updated the refunded: boolean field.

I think there are a couple of options:

1. completed_at sticks with the status completed.
2. List the statuses that are considered 'terminal' state, such as: completed, error, refunded, no_market, too_small and too_large
3. List the statuses that are considered terminal and non-errored states, such as completed, refunded.

Please feel free to comment if there are more sensible options.

[JakeUrban]

I think the third option makes the most sense. Can we update the description of completed_at? Then I'll ✅

[lijamie98]

I think the third option makes the most sense. Can we update the description of completed_at? Then I'll ✅

updated.