Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-9: Defined shared financial account fields #1367

Merged
merged 6 commits into from
Jul 6, 2023
Merged

Conversation

JakeUrban
Copy link
Contributor

@JakeUrban JakeUrban commented Jun 30, 2023

The primary use of SEP-9 fields has been for collecting information on users of Stellar-based applications, including both KYC data and off-chain financial account data.

However, SEP-9 was also intended to be used by organizations to provide information to their users. This is particularly relevant in the context of SEP-6, where organizations need to provide off-chain financial account information to their customers in order for customers to fund their deposit transactions.

This PR clarifies the set of fields that can be used by applications such as anchors to both request that information from customers and provide that information to customers.

Unrelatedly, it also makes formatting changes for improved readability.

@JakeUrban JakeUrban marked this pull request as ready for review June 30, 2023 18:20
ecosystem/sep-0009.md Outdated Show resolved Hide resolved
Address formatting varies widely from country to country and even within each country. See
[here](https://stackoverflow.com/questions/11160192/how-to-parse-freeform-street-postal-address-out-of-text-and-into-components)
for details. Rather than attempting to create a field for each possible part of an address in every country, this
protocol takes a middle of the road approach. Address fields that are fairly universal can be encoded with the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if address is universal, but we also need to include street name + building number?
What do we place in `address? Is it only building address, or full address?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think building/apt/suite numbers are typically separate optional fields in address forms. Maybe we should also have a separate field so we don't have this ambiguity?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section hasn't been changed in this PR, so I suggest we keep things as-is for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but do we have any recommendations/guidance for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we do at the moment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I think we should add some guidance for this field because right now it's quite confusing

@JakeUrban JakeUrban requested a review from Ifropc July 6, 2023 18:18
Ifropc
Ifropc previously approved these changes Jul 6, 2023
@JakeUrban JakeUrban changed the title SEP-9: Defined shared (natural person or organization) fields SEP-9: Defined shared financial account fields Jul 6, 2023
@JakeUrban JakeUrban merged commit 6f3103a into master Jul 6, 2023
2 checks passed
@JakeUrban JakeUrban deleted the sep9-split-fields branch July 6, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants