[SEP-38] Switch country code ISO #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeUrban
reviewed
Aug 24, 2023
ecosystem/sep-0038.md
Outdated
| Version 2.1.0 | ||
| Version 2.1.1 |
There was a problem hiding this comment.
I think this is a breaking change for those who expect alpha-3 codes, so we'll need to bump the major version and notify existing partners if we go with this approach.
|
This pull request is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed. |
|
@Ifropc where did we land with this, do we want to merge and update the anchor platform and notify clients? |
|
Yes, we want to merge this. No need to update the Platform, the schema is not validated on the platform |
JakeUrban
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.