[ANCHOR-505] Add fee details field to transaction object of SEP-6 and SEP-24 #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ecosystem/sep-0006.md
Ifropc
changed the title
philipliu
previously approved these changes
Jan 29, 2024
JakeUrban
reviewed
Jan 29, 2024
There was a problem hiding this comment.
I don't love that we're duplicating information on GET /quote/:id and GET /transaction?id=, is this avoidable? Am I correct in understanding that we're adding this because having fee info on the quote doesn't work when the quote is indicative or a quote is not used?
Yes, you are right. I think duplicating fee object for when the quote is used is the better option, otherwise we would need to omit it for when the quote is used (to avoid duplication), which can be confusing. |
JakeUrban
previously approved these changes
Feb 9, 2024
JakeUrban
approved these changes
Feb 9, 2024
Ifropc
added a commit
to stellar/java-stellar-anchor-sdk
that referenced
this pull request
Mar 15, 2024
…propriate RPC endpoints (#1283) ### Description Add protocol changes introduced in stellar/stellar-protocol#1441 and stellar/stellar-protocol#1429 ### Context Previously, protocol was lacking ability to break down fees being charged by the anchor. This PR adds this functionality ### Testing - `./gradlew test` ### Documentation stellar/stellar-docs#349 ### Known limitations N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently, both SEP-24 and SEP-6 offers an ability for anchor to charge fees. However, fees are only present to user as a single value (
transaction.fee, without an ability to break it down. This proposal addresses this issue with ability to specify all charges being made (such as fees, taxes), on top of the existing summary value.Proposed change
Deprecate
amount_feeandamount_fee_assetin favor of a new field:fee_details. This field follows the same schema as fee details defined in SEP-38 standard.