SEP-9 : Add external_transfer_memo field to Financial Account Fields
#1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JakeUrban, After this change how do you feel about deprecating |
Ifropc
reviewed
Mar 4, 2024
ecosystem/sep-0009.md
Outdated
| @@ -109,6 +109,7 @@ applications use fields that are the most familiar, which are often specific to | |||
| | `bank_number` | string | Number identifying bank in national banking system (routing number in US) | | |||
| | `bank_phone_number` | string | Phone number with country code for bank | | |||
| | `bank_branch_number` | string | Number identifying bank branch | | |||
| | `memo` | string | A destination tag/memo used to identify a transaction | | |||
There was a problem hiding this comment.
WDYT about renaming it to external_transfer_memo?
So it's not confused with Stellar's transaction memo
Ifropc
previously approved these changes
Mar 11, 2024
JakeUrban
previously approved these changes
Mar 11, 2024
ydag
force-pushed
the
add-memo-field-to-sep9
branch
from
dc66a19
to
34eefcc
Compare
|
@ydag could you update version and changelog of the SEP-9 file? |
ydag
changed the title
memo field to Financial Account Fieldsexternal_transfer_memo field to Financial Account Fields
Ifropc
approved these changes
Mar 18, 2024
|
Thanks for proposing this change @ydag 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving the issue #1451