Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PARTNER-278] Add on_hold status for SEP-24 tansactions #1479

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

Ifropc
Copy link
Contributor

@Ifropc Ifropc commented Apr 19, 2024

No description provided.

@Ifropc Ifropc changed the title Add on_hold status for SEP-24 tansactions [PARTNER-278] Add on_hold status for SEP-24 tansactions Apr 19, 2024
JiahuiWho
JiahuiWho previously approved these changes Apr 19, 2024
Copy link
Contributor

@philipliu philipliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. Can we also update the version and changelog?

Copy link
Contributor

@lijamie98 lijamie98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ifropc Ifropc merged commit 40d4caf into master May 1, 2024
3 checks passed
@Ifropc Ifropc deleted the sep-24-onhold branch May 1, 2024 03:28
Ifropc added a commit to stellar/java-stellar-anchor-sdk that referenced this pull request Jun 18, 2024
### Description

Added new RPC request (`notify_transaction_on_hold`) and handler for it

### Context

Add on_hold status support (introduced in
stellar/stellar-protocol#1479)

### Testing

- `./gradlew test`
- Add test for new handler

### Documentation

TODO: add documentation for this request + update diagrams
(https://stellarorg.atlassian.net/browse/ANCHOR-679 and
https://stellarorg.atlassian.net/browse/ANCHOR-688)

### Known limitations

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants