Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS Support SEP Draft #218

Merged
merged 7 commits into from
Jun 13, 2019
Merged

IPFS Support SEP Draft #218

merged 7 commits into from
Jun 13, 2019

Conversation

samsends
Copy link
Contributor

No description provided.

Copy link
Contributor

@MisterTicot MisterTicot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something I wonder about: is memo always the best place to reference IPFS data? Can't it be better to put the link in an operation - at least in some cases ?

Linking IPFS from memo:

  • Can have only 1 link per transaction
  • Can't use memo for context such as providing a txhash/id
  • You have to put an operation in there anyway

Linking IPFS from operation:

  • Can have up to 100 link per transaction
  • Can provide tx/id context in memo
  • Don't have to put a nop in the tx

I guess both approach are valid and may solve different use cases.

@stanford-scs mentioned the idea of an operation dedicated to passing data where 64 bytes would likely fit. Maybe that could be an opportunity to talk about that one.

@samsends
Copy link
Contributor Author

@stanford-scs, can you weigh in? Happy to make changes based on community feedback.

Re: 100 links per operation.
This could be achieved by combining multiple files in IPFS and then referencing the head.

I like the idea of a single DATA op that has specific account targets. This would effectively combine the two parts of the proposal since you could convey communication information and IPFS hashes.

@theaeolianmachine
Copy link
Contributor

Hi @sbsends — as part of our new process can you please do the following?

  • Pick which track you'd like to propose this idea to: Standard or Informational. Info about both can be found here: https://github.com/stellar/stellar-protocol/blob/master/ecosystem/README.md
  • Take a look at the process in the above? Once you choose the track, it's up to you to put the time into editing the draft until you're ready for bringing it to a vote. The intent will be to merge this in, and when you make a new PR moving it to Awaiting Decision we'll assign a buddy to give feedback. Any draft feedback we suggest you discuss on our public mailing list. Also, do note the new process for submitting drafts for future drafts. I'll rename and move this file, along with giving it a number when this is merged in.

@theaeolianmachine
Copy link
Contributor

Went ahead and committed this as a draft.

@theaeolianmachine theaeolianmachine merged commit 9873c6c into stellar:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants