-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPFS Support SEP Draft #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's something I wonder about: is memo always the best place to reference IPFS data? Can't it be better to put the link in an operation - at least in some cases ?
Linking IPFS from memo:
- Can have only 1 link per transaction
- Can't use memo for context such as providing a txhash/id
- You have to put an operation in there anyway
Linking IPFS from operation:
- Can have up to 100 link per transaction
- Can provide tx/id context in memo
- Don't have to put a nop in the tx
I guess both approach are valid and may solve different use cases.
@stanford-scs mentioned the idea of an operation dedicated to passing data where 64 bytes would likely fit. Maybe that could be an opportunity to talk about that one.
@stanford-scs, can you weigh in? Happy to make changes based on community feedback. Re: 100 links per operation. I like the idea of a single DATA op that has specific account targets. This would effectively combine the two parts of the proposal since you could convey communication information and IPFS hashes. |
Hi @sbsends — as part of our new process can you please do the following?
|
Went ahead and committed this as a draft. |
No description provided.