Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve & clarify interactive SEP-6 flow #342

Merged
merged 9 commits into from Jul 22, 2019
Merged

Improve & clarify interactive SEP-6 flow #342

merged 9 commits into from Jul 22, 2019

Commits on Jul 5, 2019

  1. Improve & clarify interactive SEP-6 flow

    Tom Quisel committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    00ca42b View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2019

  1. Add more advice, better /transaction response 

    * Add advice on how a wallet should use the responses it receives from the server
* Add fields to the /transaction response that the wallet needs to handle ongoing transactions
* Specify that the server should tell the wallet about the result of the interactive flow using the transaction object format, except in the case of an asynchronous deposit.
    Tom Quisel committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    32eccb2 View commit details
    Browse the repository at this point in the history

  2. Feedback

    Tom Quisel committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    2122876 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2019

  1. Address some feedback from @jimdanz

    Tom Quisel committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    5c33449 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2019

  1. remove unnecessary interactive_deposit flag

    Tom Quisel committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    f9979f8 View commit details
    Browse the repository at this point in the history

  2. Allow missing JWTs in URL

    Tom Quisel committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    1885209 View commit details
    Browse the repository at this point in the history

  3. Allow a signup form for interactive flow auth

    Tom Quisel committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    66b0fbd View commit details
    Browse the repository at this point in the history

  4. Explain interactive deposit 

    Also emphasize the interactive flow vs. SEP-12.
    Tom Quisel committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    fe8dd44 View commit details
    Browse the repository at this point in the history

  5. Convert funds -> XLM for clarity

    Tom Quisel committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    87d48fb View commit details
    Browse the repository at this point in the history