[SEP6] Expect amount from interactive webapp #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the interactive flow, we should expect the amount to come from the interactive webapp, not the wallet. This will be more clear if we can separate interactive and non-interactive into their own seps, but for now, give instruction on how to pass the amount back.
tomquisel
approved these changes
Aug 23, 2019
accordeiro
approved these changes
Aug 23, 2019
| @@ -399,6 +399,7 @@ The wallet must use the response fields in the following way to complete the wit | |||
| - `withdraw_anchor_account`: send the withdrawal payment to this Stellar account | |||
| - `withdraw_memo`: (if specified) use this memo in the payment transaction to the anchor | |||
| - `withdraw_memo_type`: use this as the memo type | |||
| - `amount_in`: the amount expected in the stellar payment | |||
There was a problem hiding this comment.
Small fix: stellar -> Stellar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interactive flow, we should expect the amount to come from the interactive webapp, not the wallet. This will be more clear if we can separate interactive and non-interactive into their own seps, but for now, give instruction on how to pass the amount back.